Hi. I have a question regarding http://code.google.com/p/libzdb/source/detail?r=538 commit.
Currently because of next check:
if (R->columns[i].buffer) { *size = (int)R->columns[i].length; return (const void *)R->columns[i].buffer; }
its possible to return a buffer with the size smaller than actual blob size. OracleResultSet_getBlob() should fall through to the loop with OCILobRead2() and RESIZE() with a check like:
if (R->columns[i].buffer == NULL) { R->columns[i].buffer = ALLOC(LOB_CHUNK_SIZE); }
prior to the loop mentioned.
Should I duplicate this mail to bugs-libzdb@tildeslash.com? Do you guys have mailing list archive available?
Hi,
It is my fault, I was not able to commit the fix due to some trips, I will commit the fix it in the end of this week.
Good luck, Volodymyr!
________________________________ From: Pavlo Lavrenenko santa@portaone.com To: libzdb-general@tildeslash.com Sent: Wednesday, April 3, 2013 3:10 PM Subject: libzdb memory leakage
Hi. I have a question regarding http://code.google.com/p/libzdb/source/detail?r=538 commit.
Currently because of next check:
if (R->columns[i].buffer) { *size = (int)R->columns[i].length; return (const void *)R->columns[i].buffer; }
its possible to return a buffer with the size smaller than actual blob size. OracleResultSet_getBlob() should fall through to the loop with OCILobRead2() and RESIZE() with a check like:
if (R->columns[i].buffer == NULL) { R->columns[i].buffer = ALLOC(LOB_CHUNK_SIZE); }
prior to the loop mentioned.
Should I duplicate this mail to bugs-libzdb@tildeslash.com? Do you guys have mailing list archive available?
-- Best regards, Pavlo Lavrenenko, PortaOne, Inc., Junior Software Developer Tel: +1-866-SIP VOIP (+1 866 747 8647) ext. 7624
PortaOne - VoIP Solutions Company Visit our Website: http://www.portaone.com -- To unsubscribe: http://www.tildeslash.com/mailman/listinfo/libzdb-general
On 04/03/2013 09:36 PM, Volodymyr Tarasenko wrote:
Hi,
It is my fault, I was not able to commit the fix due to some trips, I will commit the fix it in the end of this week.
Good luck, Volodymyr!
Oh, well, not sure if you are a busy person or just forgotten to make a commit. Anyway here is the proposed fix attached.
Hi,
The proposed fix is not quite correct: the correct way is free the buffer if it is already allocated.
Anyway the fix is committed. I would like to make OracleResultSet_getBlob more efficient, but it is not working like I expected, so I have committed the simplest fix and this explains the delay...
Good luck, Volodymyr!
________________________________ From: Pavlo Lavrenenko santa@portaone.com To: This is the libzdb general mailing list libzdb-general@tildeslash.com Sent: Wednesday, April 10, 2013 10:39 AM Subject: Re: libzdb memory leakage
On 04/03/2013 09:36 PM, Volodymyr Tarasenko wrote:
Hi,
It is my fault, I was not able to commit the fix due to some trips, I will commit the fix it in the end of this week.
Good luck, Volodymyr!
Oh, well, not sure if you are a busy person or just forgotten to make a commit. Anyway here is the proposed fix attached.
Hi Volodymyr
I have some other fixes and plan to release 2.11.2, should I wait or is the current fix good enough for now?
Best regards -- Jan-Henrik Haukeland
On Apr 10, 2013, at 1:17 PM, Volodymyr Tarasenko tvntsr@yahoo.com wrote:
Hi,
The proposed fix is not quite correct: the correct way is free the buffer if it is already allocated.
Anyway the fix is committed. I would like to make OracleResultSet_getBlob more efficient, but it is not working like I expected, so I have committed the simplest fix and this explains the delay...
Good luck, Volodymyr!
From: Pavlo Lavrenenko santa@portaone.com To: This is the libzdb general mailing list libzdb-general@tildeslash.com Sent: Wednesday, April 10, 2013 10:39 AM Subject: Re: libzdb memory leakage
On 04/03/2013 09:36 PM, Volodymyr Tarasenko wrote:
Hi,
It is my fault, I was not able to commit the fix due to some trips, I will commit the fix it in the end of this week.
Good luck, Volodymyr!
Oh, well, not sure if you are a busy person or just forgotten to make a commit. Anyway here is the proposed fix attached.
-- Best regards, Pavlo Lavrenenko, PortaOne, Inc., Junior Software Developer Tel: +1-866-SIP VOIP (+1 866 747 8647) ext. 7624
PortaOne - VoIP Solutions Company Visit our Website: http://www.portaone.com
-- To unsubscribe: http://www.tildeslash.com/mailman/listinfo/libzdb-general
-- To unsubscribe: http://www.tildeslash.com/mailman/listinfo/libzdb-general
Hi Jan-Henrik,
Lets wait for the responses on my last commit. What do you think? Could we wait till the end of week?
Good luck, Volodymyr!
________________________________ From: Jan-Henrik Haukeland hauk@tildeslash.com To: Volodymyr Tarasenko tvntsr@yahoo.com; This is the libzdb general mailing list libzdb-general@tildeslash.com Sent: Wednesday, April 10, 2013 5:35 PM Subject: Re: libzdb memory leakage
Hi Volodymyr
I have some other fixes and plan to release 2.11.2, should I wait or is the current fix good enough for now?
Best regards -- Jan-Henrik Haukeland
On Apr 10, 2013, at 1:17 PM, Volodymyr Tarasenko tvntsr@yahoo.com wrote:
Hi,
The proposed fix is not quite correct: the correct way is free the buffer if it is already allocated.
Anyway the fix is committed. I would like to make OracleResultSet_getBlob more efficient, but it is not working like I expected, so I have committed the simplest fix and this explains the delay... Good luck, Volodymyr!
From: Pavlo Lavrenenko santa@portaone.com To: This is the libzdb general mailing list libzdb-general@tildeslash.com Sent: Wednesday, April 10, 2013 10:39 AM Subject: Re: libzdb memory leakage
On 04/03/2013 09:36 PM, Volodymyr Tarasenko wrote:
Hi,
It is my fault, I was not able to commit the fix due to some trips, I will commit the fix it in the end of this week.
Good luck, Volodymyr!
Oh, well, not sure if you are a busy person or just forgotten to make a commit. Anyway here is the proposed fix attached.
-- Best regards, Pavlo Lavrenenko, PortaOne, Inc., Junior Software Developer Tel: +1-866-SIP VOIP (+1 866 747 8647) ext. 7624
PortaOne - VoIP Solutions Company Visit our Website: http://www.portaone.com
-- To unsubscribe: http://www.tildeslash.com/mailman/listinfo/libzdb-general
-- To unsubscribe: http://www.tildeslash.com/mailman/listinfo/libzdb-general
Good idea, we'll wait with the 2.11.2 release.
On Apr 10, 2013, at 4:45 PM, Volodymyr Tarasenko tvntsr@yahoo.com wrote:
Hi Jan-Henrik,
Lets wait for the responses on my last commit. What do you think? Could we wait till the end of week?
Good luck, Volodymyr!
From: Jan-Henrik Haukeland hauk@tildeslash.com To: Volodymyr Tarasenko tvntsr@yahoo.com; This is the libzdb general mailing list libzdb-general@tildeslash.com Sent: Wednesday, April 10, 2013 5:35 PM Subject: Re: libzdb memory leakage
Hi Volodymyr
I have some other fixes and plan to release 2.11.2, should I wait or is the current fix good enough for now?
Best regards
Jan-Henrik Haukeland
On Apr 10, 2013, at 1:17 PM, Volodymyr Tarasenko tvntsr@yahoo.com wrote:
Hi,
The proposed fix is not quite correct: the correct way is free the buffer if it is already allocated.
Anyway the fix is committed. I would like to make OracleResultSet_getBlob more efficient, but it is not working like I expected, so I have committed the simplest fix and this explains the delay...
Good luck, Volodymyr!
From: Pavlo Lavrenenko santa@portaone.com To: This is the libzdb general mailing list libzdb-general@tildeslash.com Sent: Wednesday, April 10, 2013 10:39 AM Subject: Re: libzdb memory leakage
On 04/03/2013 09:36 PM, Volodymyr Tarasenko wrote:
Hi,
It is my fault, I was not able to commit the fix due to some trips, I will commit the fix it in the end of this week.
Good luck, Volodymyr!
Oh, well, not sure if you are a busy person or just forgotten to make a commit. Anyway here is the proposed fix attached.
-- Best regards, Pavlo Lavrenenko, PortaOne, Inc., Junior Software Developer Tel: +1-866-SIP VOIP (+1 866 747 8647) ext. 7624
PortaOne - VoIP Solutions Company Visit our Website: http://www.portaone.com
-- To unsubscribe: http://www.tildeslash.com/mailman/listinfo/libzdb-general
-- To unsubscribe: http://www.tildeslash.com/mailman/listinfo/libzdb-general
-- To unsubscribe: http://www.tildeslash.com/mailman/listinfo/libzdb-general
-
Jan-Henrik Haukeland -
Pavlo Lavrenenko -
Volodymyr Tarasenko